Skip to content

Fix build for API routes conflict pages#7992

Merged
timneutkens merged 2 commits intovercel:canaryfrom
huv1k:api-build-fix
Jul 16, 2019
Merged

Fix build for API routes conflict pages#7992
timneutkens merged 2 commits intovercel:canaryfrom
huv1k:api-build-fix

Conversation

@huv1k
Copy link
Contributor

@huv1k huv1k commented Jul 16, 2019

Fixes #7991

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary huv1k/next.js api-build-fix Change
Build Duration 13.6s 13.5s -138ms
node_modules Size 45.5 MB 45.5 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.14 kB 4.14 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 23.7 kB 23.7 kB ✓
Client main gzip Size 7.82 kB 7.82 kB ✓
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.7 kB 59.7 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.36 kB 1.36 kB ✓
Build Dir Size 757 kB 757 kB ✓
Click to expand serverless stats
zeit/next.js canary huv1k/next.js api-build-fix Change
Build Duration 14.4s 14.8s ⚠️ +454ms
node_modules Size 45.5 MB 45.5 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.14 kB 4.14 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 23.7 kB 23.7 kB ✓
Client main gzip Size 7.82 kB 7.82 kB ✓
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.7 kB 59.7 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 338 kB 338 kB ✓
Serverless pages/link gzip Size 86.8 kB 86.8 kB -1 B
Serverless pages/index Size Error getting size Error getting size ✓
Serverless pages/index gzip Size Error getting size Error getting size ✓
Serverless pages/_error Size 328 kB 328 kB ✓
Serverless pages/_error gzip Size 84.1 kB 84.1 kB ✓
Serverless pages/routerDirect Size 330 kB 330 kB ✓
Serverless pages/routerDirect gzip Size 84.4 kB 84.4 kB ✓
Serverless pages/withRouter Size 330 kB 330 kB ✓
Serverless pages/withRouter gzip Size 84.4 kB 84.4 kB ✓
Build Dir Size 1.95 MB 1.95 MB ✓

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary huv1k/next.js api-build-fix Change
Build Duration 13s 12.7s -275ms
node_modules Size 45.5 MB 45.5 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ⚠️ +1 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 224 B 222 B -2 B
Client pages/link Size 4.14 kB 4.14 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 300 B 301 B ⚠️ +1 B
Client main Size 23.7 kB 23.7 kB ✓
Client main gzip Size 7.82 kB 7.82 kB ⚠️ +2 B
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.7 kB 59.7 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.36 kB 1.36 kB ✓
Build Dir Size 757 kB 757 kB ✓
Click to expand serverless stats
zeit/next.js canary huv1k/next.js api-build-fix Change
Build Duration 13.7s 13.7s -47ms
node_modules Size 45.5 MB 45.5 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ⚠️ +1 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 224 B 222 B -2 B
Client pages/link Size 4.14 kB 4.14 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 300 B 301 B ⚠️ +1 B
Client main Size 23.7 kB 23.7 kB ✓
Client main gzip Size 7.82 kB 7.82 kB ⚠️ +2 B
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.7 kB 59.7 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 338 kB 338 kB ✓
Serverless pages/link gzip Size 86.8 kB 86.8 kB ⚠️ +1 B
Serverless pages/index Size Error getting size Error getting size ✓
Serverless pages/index gzip Size Error getting size Error getting size ✓
Serverless pages/_error Size 328 kB 328 kB ✓
Serverless pages/_error gzip Size 84.1 kB 84.1 kB ⚠️ +1 B
Serverless pages/routerDirect Size 330 kB 330 kB ✓
Serverless pages/routerDirect gzip Size 84.4 kB 84.4 kB ⚠️ +2 B
Serverless pages/withRouter Size 330 kB 330 kB ✓
Serverless pages/withRouter gzip Size 84.4 kB 84.4 kB ⚠️ +2 B
Build Dir Size 1.95 MB 1.95 MB ✓

@timneutkens timneutkens added this to the 9.0.2 milestone Jul 16, 2019
@timneutkens timneutkens merged commit 718a36e into vercel:canary Jul 16, 2019
@panta82 panta82 mentioned this pull request Jul 25, 2019
Closed
@huv1k huv1k deleted the api-build-fix branch July 26, 2019 08:44
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.0.2

Development

Successfully merging this pull request may close these issues.

Next.js 9 Name conflict: 404 for files/folders in pages that start with api

2 participants

@huv1k @timneutkens