Skip to content

Use provided waitUntil for pending revalidates#74164

Merged
ijjk merged 4 commits intocanaryfrom
ijjk/rework-wait-until
Dec 20, 2024
Merged

Use provided waitUntil for pending revalidates#74164
ijjk merged 4 commits intocanaryfrom
ijjk/rework-wait-until

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Dec 20, 2024

Currently we are using pendingWaitUntil on renderOpts to handle pending revalidations (fetch updates and revalidate tag calls). This uses our old strategy of waitUntil inside of sendResponse which just keeps the stream open until the promise resolves. This isn't ideal if we have a proper waitUntil strategy provided so this updates to ensure we use that instead if available.

Also adds some debug logs so we can track when this pending revalidates promise is resolved.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 20, 2024
@ijjk
Copy link
Member Author

ijjk commented Dec 20, 2024 •
edited
Loading

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
buildDuration 20.7s 19s N/A
buildDurationCached 17.9s 15.4s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +37.5 kB
nextStartRea..uration (ms) 516ms 538ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
index.html gzip 522 B 524 B N/A
link.html gzip 537 B 537 B ✓
withRouter.html gzip 518 B 520 B N/A
Overall change 537 B 537 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 359 kB 359 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 141 kB 142 kB N/A
app-page-tur..prod.js gzip 137 kB 137 kB N/A
app-page.run...dev.js gzip 348 kB 348 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB N/A
app-route-ex...dev.js gzip 37.4 kB 37.5 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.3 kB 25.4 kB N/A
app-route.ru...dev.js gzip 39.1 kB 39.2 kB N/A
app-route.ru..prod.js gzip 25.3 kB 25.4 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 103 kB 103 kB ✓
build cache
vercel/next.js canary vercel/next.js ijjk/rework-wait-until Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 75.1 kB 74.4 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for edge-ssr.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: f4dd738

@ijjk ijjk added the tests label Dec 20, 2024
@ijjk ijjk merged commit 4e80990 into canary Dec 20, 2024
@ijjk ijjk deleted the ijjk/rework-wait-until branch December 20, 2024 03:41
@github-actions github-actions bot added the locked label Jan 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ztanner ztanner ztanner approved these changes

@lubakravche lubakravche lubakravche approved these changes

@huozhi huozhi Awaiting requested review from huozhi

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijjk @ztanner @lubakravche