Integrate type checking into compilation pipeline#7278
Merged
Conversation
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request runs the TypeScript type checker against the user's project and integrates the errors into the compilation pipeline.
Any files with errors are watched for only the next compilation, ensuring user's fixes trigger a recompile / type check.
The alternative approach to this would be to override the
includesproperty, but this poses a couple problems:.d.ts)I think this approach is the best of both worlds 👼.