Skip to content

fix: correct metadata url suffix (#69959)#70042

Merged
ijjk merged 1 commit into
14-2-1from
fix/og-meta
Sep 12, 2024
Merged

fix: correct metadata url suffix (#69959)#70042
ijjk merged 1 commit into
14-2-1from
fix/og-meta

Conversation

@devjiwonchoi

@devjiwonchoi devjiwonchoi commented Sep 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Backporting #69959

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. tests type: next labels Sep 12, 2024
@devjiwonchoi devjiwonchoi requested a review from ijjk September 12, 2024 18:21
@devjiwonchoi devjiwonchoi marked this pull request as ready for review September 12, 2024 18:22
@ijjk

ijjk commented Sep 12, 2024

Copy link
Copy Markdown
Member

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
buildDuration 16.5s 14.8s N/A
buildDurationCached 7.7s 7.1s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +4.18 kB
nextStartRea..uration (ms) 404ms 412ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
1103-HASH.js gzip 31.6 kB 31.6 kB N/A
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB N/A
335-HASH.js gzip 5.05 kB 5.05 kB ✓
7953.HASH.js gzip 181 B 181 B ✓
framework-HASH.js gzip 44.9 kB 44.9 kB ✓
main-app-HASH.js gzip 243 B 243 B ✓
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 50.3 kB 50.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
_app-HASH.js gzip 195 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 501 B 506 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 259 B 258 B N/A
head-HASH.js gzip 350 B 352 B N/A
hooks-HASH.js gzip 372 B 371 B N/A
image-HASH.js gzip 4.23 kB 4.23 kB ✓
index-HASH.js gzip 259 B 258 B N/A
link-HASH.js gzip 2.68 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 315 B N/A
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 4.9 kB 4.9 kB ✓
Client Build Manifests
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
_buildManifest.js gzip 483 B 483 B ✓
Overall change 483 B 483 B ✓
Rendered Page Sizes
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
index.html gzip 528 B 528 B ✓
link.html gzip 542 B 540 B N/A
withRouter.html gzip 524 B 524 B ✓
Overall change 1.05 kB 1.05 kB ✓
Edge SSR bundle Size
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
edge-ssr.js gzip 95.4 kB 95.4 kB ✓
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 95.4 kB 95.4 kB ✓
Middleware size
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
middleware-b..fest.js gzip 661 B 657 B N/A
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 995 B 995 B ✓
Next Runtimes
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
app-page-exp...dev.js gzip 171 kB 171 kB N/A
app-page-exp..prod.js gzip 98.1 kB 98.1 kB N/A
app-page-tur..prod.js gzip 99.8 kB 99.8 kB N/A
app-page-tur..prod.js gzip 94.1 kB 94.1 kB N/A
app-page.run...dev.js gzip 145 kB 145 kB N/A
app-page.run..prod.js gzip 92.6 kB 92.6 kB N/A
app-route-ex...dev.js gzip 22 kB 22 kB ✓
app-route-ex..prod.js gzip 15.5 kB 15.5 kB ✓
app-route-tu..prod.js gzip 15.5 kB 15.5 kB ✓
app-route-tu..prod.js gzip 15.2 kB 15.2 kB ✓
app-route.ru...dev.js gzip 21.7 kB 21.7 kB ✓
app-route.ru..prod.js gzip 15.2 kB 15.2 kB ✓
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB ✓
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB ✓
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.2 kB 23.2 kB ✓
pages.runtim..prod.js gzip 22.5 kB 22.5 kB ✓
server.runti..prod.js gzip 51.5 kB 51.5 kB ✓
Overall change 254 kB 254 kB ✓
build cache Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js fix/og-meta Change
0.pack gzip 1.6 MB 1.6 MB ⚠️ +1.17 kB
index.pack gzip 114 kB 113 kB N/A
Overall change 1.6 MB 1.6 MB ⚠️ +1.17 kB
Diff details
Diff for edge-ssr.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: db2def4

@ijjk

ijjk commented Sep 12, 2024

Copy link
Copy Markdown
Member

Failing test suites

Commit: db2def4

pnpm test-dev test/development/middleware-errors/index.test.ts

  • middleware - development errors > when there is a compilation error after boot > logs the error correctly
Expand output

● middleware - development errors › when there is a compilation error after boot › logs the error correctly

TIMED OUT: success

undefined

Error: expect(received).toEqual(expected) // deep equality

Expected: 2
Received: 3

  663 |
  664 |   if (hardError) {
> 665 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  666 |   }
  667 |   return false
  668 | }

  at check (lib/next-test-utils.ts:665:11)
  at Object.<anonymous> (development/middleware-errors/index.test.ts:291:9)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit fa51ff5 into 14-2-1 Sep 12, 2024
@ijjk ijjk deleted the fix/og-meta branch September 12, 2024 18:33
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devjiwonchoi @ijjk @Netail