Skip to content

Import NextInstance from e2e-utils instead#64223

Closed
eps1lon wants to merge 1 commit into
canaryfrom
sebbie/baseurl/split-c
Closed

Import NextInstance from e2e-utils instead#64223
eps1lon wants to merge 1 commit into
canaryfrom
sebbie/baseurl/split-c

Conversation

@eps1lon

@eps1lon eps1lon commented Apr 8, 2024 •
edited by padmaia
Loading

Copy link
Copy Markdown
Member

The lib path is private-ish whereas e2e-utils is a public module

Part of #64117 which I split to avoid timeouts in flake detection jobs due to large number of changed tests.

Closes NEXT-3041

@eps1lon
Import NextInstance from e2e-utils instead
6c830e7 
The lib path is private-ish whereas `e2e-utils` is a public module

Part of #64117 which I split to avoid timeouts in flake detection jobs due to large number of changed tests.
@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Apr 8, 2024
@ijjk

ijjk commented Apr 8, 2024

Copy link
Copy Markdown
Member

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
buildDuration 14.3s 14.2s N/A
buildDurationCached 8.7s 6.5s N/A
nodeModulesSize 199 MB 199 MB ✓
nextStartRea..uration (ms) 399ms 405ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 541 B ✓
withRouter.html gzip 524 B 522 B N/A
Overall change 541 B 541 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
middleware-b..fest.js gzip 626 B 626 B ✓
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 1.62 kB 1.62 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
app-page-exp...dev.js gzip 170 kB 170 kB ✓
app-page-exp..prod.js gzip 97 kB 97 kB ✓
app-page-tur..prod.js gzip 98.8 kB 98.8 kB ✓
app-page-tur..prod.js gzip 93 kB 93 kB ✓
app-page.run...dev.js gzip 144 kB 144 kB ✓
app-page.run..prod.js gzip 91.5 kB 91.5 kB ✓
app-route-ex...dev.js gzip 21.4 kB 21.4 kB ✓
app-route-ex..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route.ru...dev.js gzip 21.1 kB 21.1 kB ✓
app-route.ru..prod.js gzip 14.9 kB 14.9 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 51.1 kB 51.1 kB ✓
Overall change 945 kB 945 kB ✓
build cache
vercel/next.js canary vercel/next.js sebbie/baseurl/split-c Change
0.pack gzip 1.59 MB 1.58 MB N/A
index.pack gzip 106 kB 106 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for middleware.js

Diff too large to display

Commit: 6c830e7

@ijjk

ijjk commented Apr 8, 2024

Copy link
Copy Markdown
Member

Failing test suites

Commit: 6c830e7

pnpm test test/integration/app-dir-export/test/dynamicpage-prod.test.ts

  • app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicPage 'force-static'
Expand output

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicPage 'force-static'

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  14 |             'Page with `dynamic = "force-dynamic"` couldn\'t be exported. `output: "export"` requires all pages be renderable statically',
  15 |         },
> 16 |       ])(
     |        ^
  17 |         'should work in prod with dynamicPage $dynamicPage',
  18 |         async ({ dynamicPage, expectedErrMsg }) => {
  19 |           await runTests({ isDev: false, dynamicPage, expectedErrMsg })

  at ../node_modules/.pnpm/jest-each@29.7.0/node_modules/jest-each/build/bind.js:47:15
      at Array.forEach (<anonymous>)
  at integration/app-dir-export/test/dynamicpage-prod.test.ts:16:8
  at integration/app-dir-export/test/dynamicpage-prod.test.ts:4:56
  at Object.describe (integration/app-dir-export/test/dynamicpage-prod.test.ts:3:1)

Read more about building and testing Next.js in contributing.md.

@eps1lon eps1lon mentioned this pull request Apr 8, 2024
Merged
@eps1lon eps1lon closed this Apr 8, 2024
@eps1lon eps1lon deleted the sebbie/baseurl/split-c branch April 8, 2024 22:26
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eps1lon @ijjk