Skip to content

Inject preview props into edge manifest#64108

Merged
huozhi merged 8 commits into
canaryfrom
edge-env-injection
Apr 11, 2024
Merged

Inject preview props into edge manifest#64108
huozhi merged 8 commits into
canaryfrom
edge-env-injection

Conversation

@huozhi

@huozhi huozhi commented Apr 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

Bump the edge runtime manifest version and add environments property to each route for inlining values for deployment build.

Why

In edge runtime, extract the preview props into edge functions manifest that holding the non-deterministic inline values, then the output build will be more deterministic that helps deployment speed

x-ref: vercel/vercel#11390
x-ref: vercel/vercel#11395
Closes NEXT-3012
Closes NEXT-1912

@ijjk

ijjk commented Apr 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Tests Passed

@ijjk

ijjk commented Apr 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js edge-env-injection Change
buildDuration 14.2s 14.2s N/A
buildDurationCached 8.7s 6.5s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +5.35 kB
nextStartRea..uration (ms) 406ms 404ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js edge-env-injection Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.05 kB 5.05 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js edge-env-injection Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js edge-env-injection Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.22 kB 4.22 kB N/A
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 2.36 kB 2.36 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js edge-env-injection Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js edge-env-injection Change
index.html gzip 530 B 528 B N/A
link.html gzip 542 B 542 B ✓
withRouter.html gzip 525 B 523 B N/A
Overall change 542 B 542 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js edge-env-injection Change
edge-ssr.js gzip 95.5 kB 95.5 kB N/A
page.js gzip 3.06 kB 3.06 kB ✓
Overall change 3.06 kB 3.06 kB ✓
Middleware size
vercel/next.js canary vercel/next.js edge-env-injection Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js edge-env-injection Change
app-page-exp...dev.js gzip 170 kB 170 kB ✓
app-page-exp..prod.js gzip 97.3 kB 97.3 kB ✓
app-page-tur..prod.js gzip 99.1 kB 99.1 kB ✓
app-page-tur..prod.js gzip 93.3 kB 93.3 kB ✓
app-page.run...dev.js gzip 144 kB 144 kB ✓
app-page.run..prod.js gzip 91.8 kB 91.8 kB ✓
app-route-ex...dev.js gzip 21.4 kB 21.4 kB ✓
app-route-ex..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route.ru...dev.js gzip 21.1 kB 21.1 kB ✓
app-route.ru..prod.js gzip 14.9 kB 14.9 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.5 kB 22.5 kB ✓
server.runti..prod.js gzip 51.3 kB 51.3 kB ✓
Overall change 947 kB 947 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js edge-env-injection Change
0.pack gzip 1.58 MB 1.58 MB ⚠️ +1.28 kB
index.pack gzip 107 kB 107 kB ⚠️ +630 B
Overall change 1.69 MB 1.69 MB ⚠️ +1.91 kB
Diff details
Diff for middleware.js

Diff too large to display

Commit: 456178e

huozhi added 4 commits April 5, 2024 15:46
@huozhi
Inject edge preview props into middleware manifest
0b392d0 
update test, ignore turbo build

Revert "update test, ignore turbo build"

This reverts commit ad2a0a1.
@huozhi
separate write fn
c406bd7
@huozhi
fix version
a05fb19
@huozhi
fix middleware manifest
e1b69e8
@huozhi huozhi force-pushed the edge-env-injection branch from 121bd5e to e1b69e8 Compare April 5, 2024 13:53
@huozhi huozhi changed the title [WIP] inject preview props into edge manifest Inject preview props into edge manifest Apr 9, 2024
@huozhi huozhi force-pushed the edge-env-injection branch from 00845c0 to 5b1c672 Compare April 9, 2024 09:03
@huozhi huozhi marked this pull request as ready for review April 9, 2024 09:24
@huozhi huozhi marked this pull request as draft April 9, 2024 09:39
@huozhi huozhi marked this pull request as ready for review April 10, 2024 23:19
@huozhi huozhi merged commit cd09f8b into canary Apr 11, 2024
@huozhi huozhi deleted the edge-env-injection branch April 11, 2024 09:18
@huozhi huozhi mentioned this pull request Apr 15, 2024
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@ztanner ztanner Awaiting requested review from ztanner

@feedthejim feedthejim Awaiting requested review from feedthejim

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huozhi @ijjk