Block Certain Env Keys That Are Used Internally#6260
Merged
timneutkens merged 7 commits intocanaryfrom Feb 15, 2019
Merged
Conversation
Member
|
We don't have to block these:
What we should block:
Potentially vars starting in |
3 tasks
timneutkens
approved these changes
Feb 13, 2019
timneutkens
reviewed
Feb 13, 2019
Timer
approved these changes
Feb 15, 2019
Member
Timer
left a comment
There was a problem hiding this comment.
LGTM if tests passed (they did).
|
|
||
| #### Why This Error Occurred | ||
|
|
||
| Next.js configures internal variables for replacement itself. These start with `__` or `NODE_`, for this reason they are not allowed as values for `env` in `next.config.js` |
Member
There was a problem hiding this comment.
This might be better as:
Next.js uses special environment variables to configure itself. Because of this, you are not allowed to use values that start with
__orNODE_forenvinnext.config.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6244
This will block the following keys:
There doesn't seem to be a way to simulate a failed build or else I'd add tests for it.