Skip to content

build: remove sentry from the externals list#61194

Merged
feedthejim merged 2 commits intocanaryfrom
feedthejim/remove-sentry-external-list
Jan 26, 2024
Merged

build: remove sentry from the externals list#61194
feedthejim merged 2 commits intocanaryfrom
feedthejim/remove-sentry-external-list

Conversation

@feedthejim
Copy link
Copy Markdown
Contributor

@feedthejim feedthejim commented Jan 26, 2024 •
edited by padmaia
Loading

Context:

  • on app router, we bundle all the code used both on server and client
  • sentry used to be incompatible with that, however a raw require call on production to Sentry leads to a 350ms impact on cold boots/initial load
  • it might be ok to bundle now, let's try it out

Closes NEXT-2250

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 26, 2024
@feedthejim feedthejim merged commit 883e958 into canary Jan 26, 2024
@feedthejim feedthejim deleted the feedthejim/remove-sentry-external-list branch January 26, 2024 10:24
@github-actions github-actions bot added the locked label Feb 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@feedthejim @lforst @ijjk