Skip to content

chore: extends from shared base tsconfig#59776

Merged
huozhi merged 1 commit into
canaryfrom
polish-ts-config
Dec 19, 2023
Merged

chore: extends from shared base tsconfig#59776
huozhi merged 1 commit into
canaryfrom
polish-ts-config

Conversation

@huozhi

@huozhi huozhi commented Dec 19, 2023 •
edited by ForsakenHarmony
Loading

Copy link
Copy Markdown
Contributor

Previously the baseUrl is not aligned in root and test tsconfig, which is causing the direct import from test/* not resolved properly

e.g.

next.js/test/production/typescript-basic/index.test.ts

Line 4 in 25e0988

import { NextInstance } from 'test/lib/next-modes/base'

Using extends to align the config and fix them

Closes NEXT-1902

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Dec 19, 2023
@ijjk

ijjk commented Dec 19, 2023

Copy link
Copy Markdown
Member

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js polish-ts-config Change
buildDuration 12.6s 12.7s N/A
buildDurationCached 7.2s 6.1s N/A
nodeModulesSize 200 MB 200 MB ✓
nextStartRea..uration (ms) 420ms 427ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js polish-ts-config Change
170-HASH.js gzip 26.8 kB 26.9 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js polish-ts-config Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js polish-ts-config Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B ✓
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B ✓
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.57 kB 1.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js polish-ts-config Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js polish-ts-config Change
index.html gzip 530 B 527 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 525 B 523 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js polish-ts-config Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js polish-ts-config Change
middleware-b..fest.js gzip 627 B 621 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.07 kB 2.07 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js polish-ts-config Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 94.1 kB 94.1 kB ✓
app-page-tur..prod.js gzip 94.8 kB 94.8 kB ✓
app-page-tur..prod.js gzip 89.4 kB 89.4 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.7 kB 88.7 kB ✓
app-route-ex...dev.js gzip 24 kB 24 kB ✓
app-route-ex..prod.js gzip 16.6 kB 16.6 kB ✓
app-route-tu..prod.js gzip 16.6 kB 16.6 kB ✓
app-route-tu..prod.js gzip 16.2 kB 16.2 kB ✓
app-route.ru...dev.js gzip 23.4 kB 23.4 kB ✓
app-route.ru..prod.js gzip 16.2 kB 16.2 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.4 kB 49.4 kB ✓
Overall change 931 kB 931 kB ✓
Commit: 6db08ff

@huozhi huozhi marked this pull request as ready for review December 19, 2023 17:50
@huozhi huozhi merged commit 9d94372 into canary Dec 19, 2023
@huozhi huozhi deleted the polish-ts-config branch December 19, 2023 17:52
@github-actions github-actions Bot added the locked label Jan 3, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

1 more reviewer

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huozhi @ijjk @ForsakenHarmony