OpenTelemetry: propagate a configured context(s) to root requests#57084
Merged
feedthejim merged 3 commits intovercel:canaryfrom Oct 27, 2023
Merged
OpenTelemetry: propagate a configured context(s) to root requests#57084feedthejim merged 3 commits intovercel:canaryfrom
feedthejim merged 3 commits intovercel:canaryfrom
Conversation
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| buildDuration | 10.5s | 10.5s | N/A |
| buildDurationCached | 6s | 6.1s | N/A |
| nodeModulesSize | 175 MB | 175 MB | |
| nextStartRea..uration (ms) | 421ms | 426ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| 199-HASH.js gzip | 32.3 kB | 32.3 kB | N/A |
| 3f784ff6-HASH.js gzip | 53.2 kB | 53.2 kB | N/A |
| 99.HASH.js gzip | 182 B | 182 B | ✓ |
| framework-HASH.js gzip | 45.5 kB | 45.5 kB | ✓ |
| main-app-HASH.js gzip | 253 B | 252 B | N/A |
| main-HASH.js gzip | 35.3 kB | 35.4 kB | N/A |
| webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
| Overall change | 45.7 kB | 45.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 206 B | 205 B | N/A |
| _error-HASH.js gzip | 182 B | 180 B | N/A |
| amp-HASH.js gzip | 506 B | 505 B | N/A |
| css-HASH.js gzip | 322 B | 323 B | N/A |
| dynamic-HASH.js gzip | 2.59 kB | 2.59 kB | ✓ |
| edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 369 B | 369 B | ✓ |
| image-HASH.js gzip | 4.38 kB | 4.38 kB | N/A |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 316 B | 318 B | N/A |
| script-HASH.js gzip | 385 B | 384 B | N/A |
| withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 3.99 kB | 3.99 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 484 B | 482 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| index.html gzip | 527 B | 529 B | N/A |
| link.html gzip | 541 B | 542 B | N/A |
| withRouter.html gzip | 524 B | 524 B | ✓ |
| Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 96 kB | 96 kB | N/A |
| page.js gzip | 139 kB | 139 kB | |
| Overall change | 139 kB | 139 kB |
Middleware size
| vercel/next.js canary | dvoytenko/next.js opentelemetry/propagate | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 623 B | 625 B | N/A |
| middleware-r..fest.js gzip | 150 B | 151 B | N/A |
| middleware.js gzip | 25.8 kB | 25.8 kB | N/A |
| edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
| Overall change | 1.92 kB | 1.92 kB | ✓ |
Diff details
Diff for page.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
agadzik
requested changes
Oct 19, 2023
Member
Author
|
I added tests |
a3279f5 to
6c44e60
Compare
|
Is there any update on this being merged and going out? |
feedthejim
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement OTEL propagation according to the OpenTelemetry API per https://opentelemetry.io/docs/specs/otel/context/api-propagators/. Any configured propagator should work with this API, including
W3CTraceContextPropagator(https://www.w3.org/TR/trace-context/).Alternative to the #56891.
/cc @sfirrin