Skip to content

chore: restore options to opt-in for server-side transpilation#55010

Merged
kodiakhq[bot] merged 3 commits into
vercel:canaryfrom
feugy:chore/followup-54891
Sep 5, 2023
Merged

chore: restore options to opt-in for server-side transpilation#55010
kodiakhq[bot] merged 3 commits into
vercel:canaryfrom
feugy:chore/followup-54891

Conversation

@feugy

@feugy feugy commented Sep 5, 2023

Copy link
Copy Markdown
Member

🧐 What's in there?

As discussed with @huozhi, it's restoring code from #52393 which I forgot to restore in #54891.
It is unlikely to make a difference, but we'll set globalWindow based on the desired test environment. This will not make any difference for most people.

🧪 How to test?

Once you've rebuilt your local version of Next, pnpm testheadless jest/rsc

@feugy feugy requested review from a team, huozhi, ijjk, shuding and timneutkens as code owners September 5, 2023 12:06
@ijjk ijjk added the type: next label Sep 5, 2023
@feugy feugy force-pushed the chore/followup-54891 branch from e1d2b7b to 94bab0a Compare September 5, 2023 12:06
@ijjk

ijjk commented Sep 5, 2023

Copy link
Copy Markdown
Member

Allow CI Workflow Run

  • approve CI run for commit: 94bab0a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@kodiakhq kodiakhq Bot merged commit 39a66d5 into vercel:canary Sep 5, 2023
@feugy feugy deleted the chore/followup-54891 branch September 5, 2023 13:03
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants