Skip to content

Revert "fix(47299): allow testing pages with metadata in jsdom test environment"#54160

Merged
kodiakhq[bot] merged 1 commit into
canaryfrom
revert-53578-fix/47299-test-page-with-metadata
Aug 17, 2023
Merged

Revert "fix(47299): allow testing pages with metadata in jsdom test environment"#54160
kodiakhq[bot] merged 1 commit into
canaryfrom
revert-53578-fix/47299-test-page-with-metadata

Conversation

@huozhi

@huozhi huozhi commented Aug 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #53578

This PR (#53578) will break client components test, revert it for now.

Can repro by adding "use client" to app/page.tsx in test/production/jest/server-only.test.ts

    FAIL app/page.test.jsx
      ● Test suite failed to run·
        Cannot find module 'private-next-rsc-mod-ref-proxy' from 'app/page.jsx'·
        Require stack:

@kodiakhq kodiakhq Bot merged commit 02c258d into canary Aug 17, 2023
@kodiakhq kodiakhq Bot deleted the revert-53578-fix/47299-test-page-with-metadata branch August 17, 2023 08:49
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huozhi @timneutkens @ijjk