Skip to content

add cli version flags#435

Merged
rauchg merged 2 commits intovercel:masterfrom
lukeed:version
Dec 19, 2016
Merged

add cli version flags#435
rauchg merged 2 commits intovercel:masterfrom
lukeed:version

Conversation

@lukeed
Copy link
Copy Markdown
Contributor

@lukeed lukeed commented Dec 19, 2016

Add version printing to cli bin. Using -v or --version, (currently) prints out:

next.js v1.2.3

There aren't any bin/ tests or I would have added one.

Closes #426

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2016

Coverage Status

Coverage remained the same at 58.408% when pulling 1c30d2a on lukeed:version into e45cc89 on zeit:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2016

Coverage Status

Coverage remained the same at 58.408% when pulling 1c30d2a on lukeed:version into e45cc89 on zeit:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2016

Coverage Status

Coverage remained the same at 58.408% when pulling 44b48c5 on lukeed:version into fce87e6 on zeit:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2016

Coverage Status

Coverage remained the same at 58.408% when pulling 44b48c5 on lukeed:version into fce87e6 on zeit:master.

@rauchg rauchg merged commit ff7e128 into vercel:master Dec 19, 2016
@rauchg
Copy link
Copy Markdown
Member

rauchg commented Dec 19, 2016

Btw fly is really awesome @lukeed. Would totally welcome a PR to replace gulp with fly since it should be leaner!

@lukeed
Copy link
Copy Markdown
Contributor Author

lukeed commented Dec 19, 2016

@rauchg WOw, thanks!!

If you ever have a spare moment, I could really use another set of eyes on this issue. I'd like something better than cloning the entire instance once per task with Object.assign.. to keep true to the fast & lightweight mantra. It's the only thing keeping it in beta.

@lukeed lukeed deleted the version branch December 19, 2016 20:18
@lukeed
Copy link
Copy Markdown
Contributor Author

lukeed commented Jan 25, 2017

Would totally welcome a PR to replace gulp with fly since it should be leaner!

@rauchg If you're still up for this, I'm releasing 2.0 this weekend 😄 All bugs smoothed out! Just working on docs now.

@timneutkens
Copy link
Copy Markdown
Member

timneutkens commented Jan 25, 2017

@lukeed It might just be me, but,
Should this:

Node.js build system based in generators

Be this?

Node.js build system based on generators

@lukeed
Copy link
Copy Markdown
Contributor Author

lukeed commented Jan 25, 2017

@timneutkens Yup. I didn't write that 😇 Everything being rewritten now, and filling in all the gaps. Current README is 12+ months old & flat-out removed the old docs.

@timneutkens
Copy link
Copy Markdown
Member

timneutkens commented Jan 25, 2017

@lukeed awesome ❤️

@timneutkens
Copy link
Copy Markdown
Member

timneutkens commented Jan 25, 2017

Creating a separate issue to look into this.

@timneutkens timneutkens mentioned this pull request Jan 25, 2017
Closed
@timneutkens
Copy link
Copy Markdown
Member

timneutkens commented Jan 25, 2017

#884

@lukeed
Copy link
Copy Markdown
Contributor Author

lukeed commented Jan 25, 2017

Updated the repo description for you @timneutkens 😆

@lukeed lukeed mentioned this pull request Feb 3, 2017
Merged
3 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukeed @coveralls @rauchg @timneutkens