Skip to content

chore(devDeps): bump @vercel/ncc to 0.33.4#37113

Merged
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
SukkaW:chore-update-ncc
May 23, 2022
Merged

chore(devDeps): bump @vercel/ncc to 0.33.4#37113
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
SukkaW:chore-update-ncc

Conversation

@SukkaW
Copy link
Copy Markdown
Contributor

@SukkaW SukkaW commented May 23, 2022 •
edited
Loading

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

yarn dev failed (exit 1) on Node.js 17 & Node.js 18:

ncc_amp_optimizer failed because error:0308010C:digital envelope routines::unsupported
[...]
ncc_next__react_dev_overlay failed because error:0308010C:digital envelope routines::unsupported

The issue was reported to @vercel/ncc (vercel/ncc#805) and fixed by vercel/ncc#868, and @vercel/ncc@0.33.2 includes the fix. However, Next.js still uses @vercel/ncc@0.33.1 in devDependencies.

The PR bump @vercel/ncc to the latest version (which is 0.33.4).

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next labels May 23, 2022
@ijjk
Copy link
Copy Markdown
Member

ijjk commented May 23, 2022 •
edited
Loading

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
buildDuration 20.5s 20.8s ⚠️ +221ms
buildDurationCached 8.1s 8s -129ms
nodeModulesSize 479 MB 479 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
/ failed reqs 0 0 ✓
/ total time (seconds) 5.382 5.409 ⚠️ +0.03
/ avg req/sec 464.49 462.22 ⚠️ -2.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.142 2.18 ⚠️ +0.04
/error-in-render avg req/sec 1167.19 1146.58 ⚠️ -20.61
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 73 kB 73 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.73 kB 5.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 529 B 529 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC
General
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
buildDuration 23.6s 23.2s -317ms
buildDurationCached 7.9s 7.7s -253ms
nodeModulesSize 479 MB 479 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
/ failed reqs 0 0 ✓
/ total time (seconds) 5.285 5.371 ⚠️ +0.09
/ avg req/sec 473.07 465.45 ⚠️ -7.62
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.139 2.122 -0.02
/error-in-render avg req/sec 1168.61 1178.41 +9.8
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.7 kB 29.7 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 74.1 kB 74.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.82 kB 5.82 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.78 kB 2.78 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ✓
Client Build Manifests
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js chore-update-ncc Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 59db71e

ijjk
ijjk previously approved these changes May 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Copy Markdown
Member

ijjk commented May 23, 2022

Failing test suites

Commit: 3243113

yarn testheadless test/integration/async-modules/test/index.test.js

  • Async modules > dev mode > can render async AMP pages
  • Async modules > serverless mode > can render async AMP pages
Expand output

● Async modules › dev mode › can render async AMP pages

TIMED OUT: just now

14 seconds ago

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/async-modules/test/index.test.js:85:7)

● Async modules › serverless mode › can render async AMP pages

TIMED OUT: just now

20 seconds ago

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/async-modules/test/index.test.js:85:7)

Read more about building and testing Next.js in contributing.md.

@SukkaW SukkaW requested a review from ijjk May 23, 2022 19:27
@kodiakhq kodiakhq bot merged commit d64512f into vercel:canary May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
@SukkaW SukkaW deleted the chore-update-ncc branch October 24, 2023 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees

No one assigned

Labels

create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SukkaW @ijjk