Skip to content

Optimize the web server size#34242

Merged
kodiakhq[bot] merged 5 commits into
vercel:canaryfrom
shuding:shu/0616
Feb 11, 2022
Merged

Optimize the web server size#34242
kodiakhq[bot] merged 5 commits into
vercel:canaryfrom
shuding:shu/0616

Conversation

@shuding

@shuding shuding commented Feb 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Related to #34185, this PR reduces the size of chunk that contains web-server.ts from 1.14mb to 210.8kb, by splitting base-http and api-utils into different environments.

Only affected thing is we can't have SSG preview mode for the web runtime via getStaticProps.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 11, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment was marked as outdated.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@shuding shuding marked this pull request as ready for review February 11, 2022 19:21
@ijjk

ijjk commented Feb 11, 2022

Copy link
Copy Markdown
Member

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/0616 Change
buildDuration 15.7s 15.5s -148ms
buildDurationCached 6.1s 6.1s ⚠️ +79ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.84 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/0616 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.167 3.211 ⚠️ +0.04
/ avg req/sec 789.27 778.56 ⚠️ -10.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.377 1.346 -0.03
/error-in-render avg req/sec 1815.82 1857.31 +41.49
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/0616 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/0616 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/0616 Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.01 kB 5.01 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/0616 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/0616 Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/0616 Change
buildDuration 19.1s 19.2s ⚠️ +50ms
buildDurationCached 6.1s 6.2s ⚠️ +53ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.84 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/0616 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.165 3.191 ⚠️ +0.03
/ avg req/sec 789.93 783.33 ⚠️ -6.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.347 1.358 ⚠️ +0.01
/error-in-render avg req/sec 1856.35 1840.63 ⚠️ -15.72
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/0616 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.7 kB 71.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/0616 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/0616 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/0616 Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/0616 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: da2609e

@kodiakhq kodiakhq Bot merged commit 6bc7c4d into vercel:canary Feb 11, 2022
@shuding shuding deleted the shu/0616 branch February 11, 2022 20:19
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@padmaia padmaia Awaiting requested review from padmaia

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuding @ijjk @huozhi