Skip to content

Commit 315dc3c

Browse files
committed
clarity
1 parent 25f7f8e commit 315dc3c

1 file changed

Lines changed: 10 additions & 7 deletions

File tree

turbopack/crates/turbo-tasks-backend/src/backend/operation/connect_child.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ impl ConnectChildOperation {
2626
pub fn run(
2727
parent_task_id: TaskId,
2828
child_task_id: TaskId,
29-
mut is_immutable: bool,
29+
mut is_child_immutable: bool,
3030
mut ctx: impl ExecuteContext,
3131
) {
3232
if !ctx.should_track_children() {
3333
let mut task = ctx.task(child_task_id, TaskDataCategory::All);
34-
if is_immutable {
34+
if is_child_immutable {
3535
task.mark_as_immutable();
3636
}
3737
if !task.has_key(&CachedDataItemKey::Output {}) {
@@ -45,9 +45,9 @@ impl ConnectChildOperation {
4545
return;
4646
}
4747

48-
if !is_immutable {
48+
if !is_child_immutable {
4949
let task = ctx.task(child_task_id, TaskDataCategory::All);
50-
is_immutable = task.is_immutable();
50+
is_child_immutable = task.is_immutable();
5151
}
5252

5353
let mut parent_task = ctx.task(parent_task_id, TaskDataCategory::All);
@@ -58,7 +58,10 @@ impl ConnectChildOperation {
5858
};
5959

6060
// Quick skip if the child was already connected before
61-
if new_children.insert(child_task_id, is_immutable).is_some() {
61+
if new_children
62+
.insert(child_task_id, is_child_immutable)
63+
.is_some()
64+
{
6265
return;
6366
}
6467

@@ -82,13 +85,13 @@ impl ConnectChildOperation {
8285
}
8386

8487
// Immutable tasks cannot be invalidated, meaning that we never reschedule them.
85-
if !is_immutable && ctx.should_track_activeness() {
88+
if !is_child_immutable && ctx.should_track_activeness() {
8689
queue.push(AggregationUpdateJob::IncreaseActiveCount {
8790
task: child_task_id,
8891
});
8992
} else {
9093
let mut task = ctx.task(child_task_id, TaskDataCategory::All);
91-
if is_immutable {
94+
if is_child_immutable {
9295
task.mark_as_immutable();
9396
}
9497

0 commit comments

Comments
 (0)