Skip to content

Webpack tests#24

Merged
timneutkens merged 2 commits intowebpackfrom
webpack-tests
Nov 20, 2018
Merged

Webpack tests#24
timneutkens merged 2 commits intowebpackfrom
webpack-tests

Conversation

@rauchg
Copy link
Member

@rauchg rauchg commented Nov 19, 2018

@rauchg rauchg requested a review from timneutkens November 19, 2018 23:06
@timneutkens
Copy link
Member

timneutkens commented Nov 19, 2018

Shouldn't these builds fail? Or is it because at runtime they break

@rauchg
Copy link
Member Author

rauchg commented Nov 19, 2018

They fail locally for me. Maybe CI wasn't set up correctly?

  ✕ should evaluate apollo.js without errors (5165ms)
  ✕ should evaluate auth0.js without errors (5022ms)
  ✓ should evaluate aws-sdk.js without errors (2969ms)
  ✓ should evaluate axios.js without errors (2285ms)
  ✓ should evaluate core-js.js without errors (1352ms)
  ✓ should evaluate cowsay.js without errors (49ms)
  ✓ should evaluate firebase.js without errors (310ms)
  ✕ should evaluate google-datastore.js without errors (5010ms)
  ✓ should evaluate ioredis.js without errors (1234ms)
  ✓ should evaluate jimp.js without errors (1180ms)
  ✓ should evaluate json-without-ext-sample.json without errors (19ms)
  ✓ should evaluate json-without-ext.js without errors (18ms)
  ✓ should evaluate koa.js without errors (569ms)
  ✓ should evaluate mailgun.js without errors (26ms)
  ✓ should evaluate mariadb.js without errors (524ms)
  ✓ should evaluate memcached.js without errors (83ms)
  ✓ should evaluate mongoose.js without errors (2314ms)
  ✓ should evaluate mysql.js without errors (798ms)
  ✓ should evaluate pdfkit.js without errors (1800ms)
  ✓ should evaluate pg.js without errors (352ms)
  ✓ should evaluate react.js without errors (95ms)
  ✓ should evaluate redis.js without errors (285ms)
  ✓ should evaluate request.js without errors (2237ms)
  ✓ should evaluate rxjs.js without errors (1564ms)
  ✓ should evaluate saslprep.js without errors (41ms)
  ✓ should evaluate sentry.js without errors (524ms)
  ✓ should evaluate stripe.js without errors (402ms)
  ✕ should evaluate twilio.js without errors (5008ms)

@rauchg rauchg mentioned this pull request Nov 19, 2018
Merged
@timneutkens timneutkens merged commit 2e82a24 into webpack Nov 20, 2018
@timneutkens timneutkens deleted the webpack-tests branch November 20, 2018 13:04
@timneutkens timneutkens mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rauchg @timneutkens