Asset directory emission, test refactoring#106
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 73.31% 75.06% +1.75%
==========================================
Files 6 6
Lines 356 385 +29
==========================================
+ Hits 261 289 +28
- Misses 95 96 +1
Continue to review full report at Codecov.
|
|
@guybedford I'm getting the error with the latest version. I've updated in #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68.
This extends asset emission to direct emission of directories, fixing the strong-globalize test case.
I also went ahead and refactored the tests to use the "run" approach over an embedded eval. This simplifies the source maps handling but did require rewriting out the module.exports execution. Top-level promises work out here fine though since as a separate process, each test runs to completion.
This does not close #58 as it is effectively just the first step of that.