Skip to content

Consider inlining files that are read via the fs API #3

@rauchg

Description

@rauchg

If I manually "fix" #2 by adding iconv-lite, I get:

▲  play-ncc/ node out.js
fs.js:122
    throw err;
    ^

Error: ENOENT: no such file or directory, open '/Users/rauchg/Projects/play-ncc/data.trie'
    at Object.openSync (fs.js:448:3)
    at Object.readFileSync (fs.js:348:35)
    at /Users/rauchg/Projects/play-ncc/out.js:1:85193
    at createCommonjsModule (/Users/rauchg/Projects/play-ncc/out.js:1:677)
    at Object.<anonymous> (/Users/rauchg/Projects/play-ncc/out.js:1:85090)
    at Module._compile (internal/modules/cjs/loader.js:707:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:718:10)
    at Module.load (internal/modules/cjs/loader.js:605:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
    at Function.Module._load (internal/modules/cjs/loader.js:536:3)

This thread is for us to discuss the static analysis possibilities around detecting filesystem reads and embedding them in the resulting artifact.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions