Conversation
fixes vercel#37 I had some difficulties getting codecov to work with the existing circleci config. Wasn't really sure why a Docker build was being done, didn't seem to need to be. And ... a Docker image was being built but not actually run? Not sure what was going on there. So, I copied from the following circleci config instead: - https://github.com/zeit/dns-cached-resolve/blob/master/.circleci/config.yml To enable the codecov bits to work: - the GH repo will need to be set up in codecov.io - this will create a token to be used when uploading the codecov file(s) - that token should be added as an env var in circleci named CODECOV_TOKEN - voilà, should work
|
Tests in docker provide a way to test locally and remotely in an environment that is more or less deterministic. The format of a Dockerfile is easily learned and quite ubiquitous and cuts out guesswork for making sure dependencies are installed correctly. This was intentional. Please don't remove it. |
|
Ah, I see - an interesting little hack to get a stable env to run tests against. I don't think I've ever seen usage of A few problems though, getting codecov integrated with this:
It was getting ugly as I was getting closer to making this work with the existing structure, and so decided to look at how other folks were using circleci. It doesn't seem like there's going to be much different - deterministically - between the Dockerfile and what's going on in circleci with the new config. Or maybe I'm missing something. So, I'm curious if you want the If just for ad-hoc testing, it should probably be moved out of the |
Install codecov's reporter from inside the docker image, of course
Then remove
In the config yaml file: |
fixes #37
I had some difficulties getting codecov to work with the existing
circleci config. Wasn't really sure why a Docker build was being
done, didn't seem to need to be. And ... a Docker image was being
built but not actually run? Not sure what was going on there.
So, I copied from the following circleci config instead:
To enable the codecov bits to work: