Skip to content

fix (provider-utils): remove deprecated CoreToolCall and CoreToolResult types#5776

Merged
gr2m merged 3 commits intov5from
v5-5765-remove-CoreTool-types-from-provider-utils
Apr 15, 2025
Merged

fix (provider-utils): remove deprecated CoreToolCall and CoreToolResult types#5776
gr2m merged 3 commits intov5from
v5-5765-remove-CoreTool-types-from-provider-utils

Conversation

@gr2m
Copy link
Copy Markdown
Collaborator

@gr2m gr2m commented Apr 15, 2025

Background

Towards #5765

Summary

Removes deprecated CoreToolCall and CoreToolResult types

Tasks

  • n/a Tests for the changes have been added (for bug fixes / features)
  • n/a Docs have been added / updated (for bug fixes / features)
  • If required, a patch changeset for relevant packages has been added
  • You've run pnpm prettier-fix to fix any formatting issues

@@ -0,0 +1,5 @@
---
'@ai-sdk/provider-utils': major
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used major since it's removing an API, but the pull request template calls explicitly for a patch type. Let me know what your preference is

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on v5 it does not matter, the release will be major regardless.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's clear. But I think it might help with the release notes / upgrade guide when we flag breaking changes explicitly?

@gr2m gr2m mentioned this pull request Apr 15, 2025
8 tasks
Comment thread packages/ai/core/generate-text/index.ts Outdated
ToolCall,
ToolCallUnion,
} from './tool-call';
export type { CoreToolCallUnion, ToolCall, ToolCallUnion } from './tool-call';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm CoreToolCallUnion?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or was that in the other pr?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that was removed in https://github.com/vercel/ai/pull/5768/files#diff-97e4c4e0b8b41041865409d1692cc8374efa62a36b8a50e736e799fb46829255L26, I'll merge v5 into this branch as it caused conflicts. I tried to split up the changes by packages for easier reviews

@gr2m gr2m changed the title V5 5765 remove core tool types from provider utils fix (provider-utils): remove deprecated CoreToolCall and CoreToolResult types Apr 15, 2025
@gr2m gr2m merged commit 5d142ab into v5 Apr 15, 2025
7 checks passed
@gr2m gr2m deleted the v5-5765-remove-CoreTool-types-from-provider-utils branch April 15, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants