fix (provider): remove obsolete .rawCall from doStream() and doGenerate() results (now there is request)#5774
Closed
fix (provider): remove obsolete .rawCall from doStream() and doGenerate() results (now there is request)#5774
.rawCall from doStream() and doGenerate() results (now there is request)#5774Conversation
…enerate()` results (now there is request)
gr2m
commented
Apr 15, 2025
| /** | ||
| Raw prompt and setting information for observability provider integration. | ||
| */ | ||
| // TODO v2: remove in v2 (now there is request) |
Collaborator
Author
There was a problem hiding this comment.
I assume that "request" is referring to the .request key:
ai/packages/provider/src/language-model/v1/language-model-v1.ts
Lines 164 to 173 in 56faf0d
But that key is marked as optional, while .rawCall seems to have always been present.
Maybe the .request key should not be optional?
lgrammel
requested changes
Apr 15, 2025
Collaborator
lgrammel
left a comment
There was a problem hiding this comment.
We do not change LanguageModelV1 - it is left for reference and will be fully removed before the V5 release. This has been fixed in LangaugeModelV2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Towards #5765
Summary
Obsolete
.rawCallfromdoStream()anddoGenerate()results has been removed. Use.requestinstead.Tasks
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)pnpm prettier-fixto fix any formatting issues