fix regex in smoothStream()#5475
Closed
carlbrugger wants to merge 4 commits intovercel:mainfrom
carlbrugger:patch-1
Closed
fix regex in smoothStream()#5475carlbrugger wants to merge 4 commits intovercel:mainfrom carlbrugger:patch-1
carlbrugger wants to merge 4 commits intovercel:mainfrom
carlbrugger:patch-1
Conversation
Collaborator
|
I have doubts re the replacement regexp. Won't it match way to much, causing half-finished words to be streamed out? Instead I'll look into flushing the buffer when there is a tool call, which should cover all cases. |
Contributor
Author
|
@lgrammel I've changed the implementation to flush the buffer when the chunk type changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The word-based regex pattern
/\s*\S+\s+/mrequires trailing whitespace after each word. The lasttext-deltawon't have a trailing space causing the last word in the lasttext-deltato not be returned until after any tool calls the model may make. The proposed solution is to match words even if they don't have trailing whitespace.Resolves #5493