Skip to content

feat (ai/core): add finish event and avg output tokens per second (telemetry) #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgrammel merged 10 commits into from
Sep 2, 2024
Merged

feat (ai/core): add finish event and avg output tokens per second (telemetry) #2872

lgrammel merged 10 commits into from
Sep 2, 2024

Conversation

@lgrammel
Copy link
Collaborator

@lgrammel lgrammel commented Sep 2, 2024 •
edited
Loading

Summary

  • rename ai.result.text to ai.response.text
  • rename ai.result.toolCalls to ai.response.toolCalls
  • rename ai.result.object to ai.response.object
  • rename ai.stream.msToFirstChunk to ai.response.msToFirstChunk
  • rename ai.finishReason to ai.response.finishReason
  • add ai.response.msToFinish (streamText)
  • add ai.response.avgCompletionTokensPerSecond (streamText)
  • add ai.stream.finish event (streamText)

@lgrammel lgrammel self-assigned this Sep 2, 2024
@lgrammel lgrammel changed the title wip feat (ai/core): add finish event and avg output tokens per second (telemetry) Sep 2, 2024
@lgrammel lgrammel marked this pull request as ready for review September 2, 2024 16:22
@lgrammel lgrammel merged commit dad775f into main Sep 2, 2024
@lgrammel lgrammel deleted the lg/telemetry-derived-stats branch September 2, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoalbanese nicoalbanese nicoalbanese approved these changes

Assignees

@lgrammel lgrammel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lgrammel @nicoalbanese