fix(ai): make experimental_context required in ToolLoopAgentOnFinishCallback#12219
Merged
dancer merged 4 commits intovercel:mainfrom Feb 9, 2026
Merged
Conversation
…allback This fixes a type inconsistency where ToolLoopAgentOnFinishCallback had experimental_context as optional while StreamTextOnFinishCallback and GenerateTextOnFinishCallback had it as required. Since ToolLoopAgent delegates to streamText/generateText, and both always pass experimental_context when invoking the callback, the types should match. Fixes vercel#12195
Contributor
Author
dancer
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolLoopAgentOnFinishCallbackhadexperimental_contextas optional (?) whileStreamTextOnFinishCallbackandGenerateTextOnFinishCallbackhad it as requiredProblem
As reported in #12195,
ToolLoopAgentOnFinishCallbackdefinesexperimental_context?: unknown(optional), butStreamTextOnFinishCallbackandGenerateTextOnFinishCallbackdefineexperimental_context: unknown(required).Since
ToolLoopAgentdelegates tostreamText/generateText, and both always passexperimental_contextwhen invoking the callback (stream-text.ts#L1011, generate-text.ts#L940), the types should match.This inconsistency causes type errors when trying to use a
StreamTextOnFinishCallbackwhereToolLoopAgentOnFinishCallbackis expected (or vice versa).Solution
Changed
experimental_context?: unknowntoexperimental_context: unknowninToolLoopAgentOnFinishCallbackto match the other callback types.Testing
StreamTextOnFinishCallbackandToolLoopAgentOnFinishCallbackFixes #12195