fix(bedrock): map reasoningConfig to reasoning_effort for openai models#11620
Merged
aayush-kapoor merged 2 commits intomainfrom Jan 8, 2026
Merged
fix(bedrock): map reasoningConfig to reasoning_effort for openai models#11620aayush-kapoor merged 2 commits intomainfrom
aayush-kapoor merged 2 commits intomainfrom
Conversation
4 tasks
|
|
||
| const maxReasoningEffort = | ||
| bedrockOptions.reasoningConfig?.maxReasoningEffort; | ||
| const isOpenAIModel = this.modelId.startsWith('openai.'); |
Contributor
There was a problem hiding this comment.
OpenAI models should use reasoning_effort directly, not reasoningConfig, when handling maxReasoningEffort
lgrammel
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
#11467
Improper mapping of
reasoningConfigto it's equivalentreasoning_effortwhen using openAI models in bedrockSummary
swap in
reasoning_effortparam for when an openai model is usedManual Verification
verified by running the cli example in
examples/ai-core/src/generate-text/bedrock-openai-reasoning.tswhich failed before the fix.Checklist
pnpm changesetin the project root)Related Issues
Fixes #11467