EIP1056Registry - standardized contract interface#60
Merged
mirceanis merged 8 commits intoveramolabs:mainfrom Nov 2, 2023
Merged
EIP1056Registry - standardized contract interface#60mirceanis merged 8 commits intoveramolabs:mainfrom
mirceanis merged 8 commits intoveramolabs:mainfrom
Conversation
jac18281828
commented
Oct 19, 2023
| FROM debian:stable-slim as python-builder | ||
| FROM ghcr.io/xmtp/foundry:latest | ||
|
|
||
| # python3.10 is required for node-gyp |
Collaborator
Author
There was a problem hiding this comment.
Python 3.10 is no longer required on the latest hardhat and node versions (solc 0.8.21)
mirceanis
requested changes
Oct 30, 2023
Contributor
mirceanis
left a comment
There was a problem hiding this comment.
Looks great!
I added some suggestions for a couple of inline docs that were wrong about the return type. Please fix those before we merge.
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #57