Solidity test - with signature test - working#59
Merged
mirceanis merged 3 commits intoveramolabs:mainfrom Oct 17, 2023
Merged
Conversation
Delegate and Attribute complete closes veramolabs#56
mirceanis
requested changes
Oct 10, 2023
Contributor
mirceanis
left a comment
There was a problem hiding this comment.
I'm still reviewing. It's a massive change so it will take a while longer :/
I decided to share some of my notes as I might be misunderstanding some things (I haven't used foundry before).
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
mirceanis
approved these changes
Oct 17, 2023
Contributor
mirceanis
left a comment
There was a problem hiding this comment.
This looks great!
I think it's a solid foundation to build further features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegate and Attribute complete
closes #56
This PR introduces comprehensive testing in Solidity for the
did-eth-registry. By consolidating our tests within a single high-performance Solidity framework, we simplify future improvements and refactoring efforts. This approach also eliminates the need to switch between different language implementations, streamlining our development process.