Validate generic headers#87
Merged
yogeshbdeshpande merged 1 commit intoveraison:mainfrom Jul 11, 2022
Merged
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
yogeshbdeshpande
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR validates that the Common COSE Headers Parameters have to correct type.
The change has been quite disruptive for our test cases, because we were using headers containing invalid parameters. Most of the test changes are related to fixing those tests.
This PR does not validate counter signature nor x509 common parameters, as go-cose currently does not expose the CBOR types which are contained in those parameters.
Fix #82
Signed-off-by: qmuntal qmuntaldiaz@microsoft.com