Remove cose.Verify1 and update cose.Sign1#67
Merged
yogeshbdeshpande merged 4 commits intoveraison:mainfrom May 20, 2022
Merged
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
shizhMSFT
reviewed
May 18, 2022
Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
e8754a7 to
02a1b14
Compare
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
shizhMSFT
reviewed
May 19, 2022
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements what has been discussed at #64:
cose.Verify1. It is not clear which use case does it cover, as one normally wants to have the decoded payload, not only verify a message, but this function only does the later.cose.Sign1to also perform the encoding of the message and return the encoded bytes instead of aSign1Messagestruct.Closes #64
Signed-off-by: qmuntal qmuntaldiaz@microsoft.com