Skip to content

Update readme with release info#65

Merged
yogeshbdeshpande merged 1 commit intoveraison:mainfrom
SteveLasker:alpha1-prep
May 10, 2022
Merged

Update readme with release info#65
yogeshbdeshpande merged 1 commit intoveraison:mainfrom
SteveLasker:alpha1-prep

Conversation

@SteveLasker
Copy link
Copy Markdown
Contributor

Signed-off-by: Steve Lasker stevenlasker@hotmail.com

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-fossati
Copy link
Copy Markdown
Contributor

I am slightly confused. In the README, we previously had warnings around the SignMessage interface being experimental. Unless I'm looking at the wrong file, they seem to have disappeared? Help me understand :-)

@yogeshbdeshpande
Copy link
Copy Markdown
Contributor

I am slightly confused. In the README, we previously had warnings around the SignMessage interface being experimental. Unless I'm looking at the wrong file, they seem to have disappeared? Help me understand

@thomas-fossati This has happened because Steve has raised a PR from this fork, which is not rebased to latest on master(main) go-cose.

He need to do that before he merges to master and retain the change you have done in the previous commit.

@SteveLasker
Copy link
Copy Markdown
Contributor Author

Ahhh, thank you for the catch, i’ll fix later today.
@yogeshbdeshpande, looks like a DCO error got introduced.

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
@yogeshbdeshpande yogeshbdeshpande merged commit 84fb267 into veraison:main May 10, 2022
@SteveLasker SteveLasker deleted the alpha1-prep branch May 10, 2022 21:54
@SteveLasker
Copy link
Copy Markdown
Contributor Author

Thank you @yogeshbdeshpande

@SteveLasker SteveLasker mentioned this pull request May 10, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants