Skip to content

Use curve modulo instead of field size to calculate ECDSA signature length#60

Merged
SteveLasker merged 1 commit intoveraison:mainfrom
qmuntal:ecdsa/length
May 4, 2022
Merged

Use curve modulo instead of field size to calculate ECDSA signature length#60
SteveLasker merged 1 commit intoveraison:mainfrom
qmuntal:ecdsa/length

Conversation

@qmuntal
Copy link
Copy Markdown
Member

@qmuntal qmuntal commented May 3, 2022

…ength

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@SteveLasker
Copy link
Copy Markdown
Contributor

SteveLasker commented May 3, 2022

@sylvanc, @roywill can you also please provide some 👀's

Copy link
Copy Markdown
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveLasker
Copy link
Copy Markdown
Contributor

Thanks @qmuntal, @jaredpar, @yogeshbdeshpande
@pornin, do you mind taking a look to confirm it meets your goals for #59?

@pornin
Copy link
Copy Markdown

pornin commented May 4, 2022

The change to ecdsa.go is exactly what I had in mind.

@SteveLasker
Copy link
Copy Markdown
Contributor

Thanks @pornin, awesome work @qmuntal

@SteveLasker SteveLasker merged commit b06d841 into veraison:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field/order size confusion in ECDSA signature length

6 participants