Merged
Conversation
Fix #55 Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
2fbba11 to
fd82999
Compare
Contributor
|
Just
to the comments? Or, is that too much? And, we can do that in the readme. |
Contributor
Author
I think adding that to each code comment would be a tad too heavy. Apropos of COSE_Sign, the README says : "[...] In addition, the amount of functional and security testing it has received so far is significantly lower than the COSE_Sign1 API." which seems to capture the same semantics as you suggest above, although in reverse. |
yogeshbdeshpande
approved these changes
Apr 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #55