Skip to content

Sign1 bells and whistles#2

Merged
thomas-fossati merged 4 commits intomasterfrom
precond
Nov 25, 2020
Merged

Sign1 bells and whistles#2
thomas-fossati merged 4 commits intomasterfrom
precond

Conversation

@thomas-fossati
Copy link
Copy Markdown
Contributor

@thomas-fossati thomas-fossati commented Nov 24, 2020 •
edited
Loading

  • check all preconditions are met on Sign1 messages sent for signature & verification
  • add Sign1 example code
  • add further tests
  • update README with information about the fork and a pointer to the Sign1 example
  • add Sign1 specific error codes

SimonFrost-Arm
SimonFrost-Arm approved these changes Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown

@SimonFrost-Arm SimonFrost-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-fossati thomas-fossati merged commit de93f60 into master Nov 25, 2020
@thomas-fossati thomas-fossati deleted the precond branch March 23, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@setrofim setrofim setrofim approved these changes

@SimonFrost-Arm SimonFrost-Arm SimonFrost-Arm approved these changes

@mangup01 mangup01 Awaiting requested review from mangup01

@yogeshbdeshpande yogeshbdeshpande Awaiting requested review from yogeshbdeshpande

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomas-fossati @setrofim @SimonFrost-Arm