Improve Algorithm.String() message for unknown values#167
Merged
SteveLasker merged 1 commit intomainfrom Aug 25, 2023
Merged
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
setrofim
approved these changes
Aug 18, 2023
SteveLasker
approved these changes
Aug 25, 2023
Contributor
SteveLasker
left a comment
There was a problem hiding this comment.
LGTM for more detail surfaced for diagnostics
Contributor
|
Thanks @hslatman for the initial PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
Algorithm.Stringmessage for values not defined in go-cose.For example, when calling
Algorithm(7).String(), it previously returnedunknown algorithm value 7. Considering that other libraries can define their own algorithms, IMO that message is too verbose and seems more like an error than a useful name.With the new behavior, the returned string will be
Algorithm(7).While here, fix #164.