Centralize key validations and check more invalid cases#156
Merged
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 91.05% 91.52% +0.47%
==========================================
Files 12 12
Lines 1542 1545 +3
==========================================
+ Hits 1404 1414 +10
+ Misses 101 94 -7
Partials 37 37
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
setrofim
approved these changes
Jul 5, 2023
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
setrofim
approved these changes
Jul 5, 2023
Member
Author
|
@thomas-fossati @yogeshbdeshpande @shizhMSFT please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Key.Validateprivate. The checks in that method are not exhaustive, e.g., we not validating that the key cryptographically ok. I would rather keep it private so we can evolve it without being tied to an specific behavior.Key.PublicKeyandKey.PrivateKeynow callKey.validateso we don't return a malformed key.NewSymmetricKeyno longer returns an error, as this function can't fail.