Skip to content

fix: typo UnataggedSign1Message -> UntaggedSign1Message#148

Merged
yogeshbdeshpande merged 1 commit intoveraison:mainfrom
spennymac:smccreary/typo-fix
Jul 4, 2023
Merged

fix: typo UnataggedSign1Message -> UntaggedSign1Message#148
yogeshbdeshpande merged 1 commit intoveraison:mainfrom
spennymac:smccreary/typo-fix

Conversation

@spennymac
Copy link
Copy Markdown
Contributor

Small change to fix the typo.

@spennymac
Copy link
Copy Markdown
Contributor Author

Issue: #149

Copy link
Copy Markdown
Contributor

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2023

Codecov Report

Merging #148 (e4012fa) into main (354ac99) will decrease coverage by 1.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   92.76%   90.87%   -1.90%     
==========================================
  Files          10       12       +2     
  Lines        1065     1611     +546     
==========================================
+ Hits          988     1464     +476     
- Misses         51      109      +58     
- Partials       26       38      +12     
Impacted Files Coverage Δ
sign1.go 90.10% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spennymac
Copy link
Copy Markdown
Contributor Author

Need one more reviewer :)

Signed-off-by: Spencer McCreary <smccreary@squareup.com>
Copy link
Copy Markdown
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for spotting this

@yogeshbdeshpande yogeshbdeshpande merged commit 8ba8d69 into veraison:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants