Merged
Conversation
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 91.82% 92.77% +0.95%
==========================================
Files 10 10
Lines 978 1024 +46
==========================================
+ Hits 898 950 +52
+ Misses 54 49 -5
+ Partials 26 25 -1 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
SteveLasker
requested changes
Feb 25, 2023
Contributor
SteveLasker
left a comment
There was a problem hiding this comment.
go-cose is under MPL, based on its history.
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
SteveLasker
approved these changes
Feb 27, 2023
Contributor
SteveLasker
left a comment
There was a problem hiding this comment.
LGTM, thanks @toddysm
Contributor
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
Kindly address these comments
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Toddy Mladenov toddysm@gmail.com