Skip to content

Use cbor.SortCoreDeterministic for CBOR encoding#113

Merged
thomas-fossati merged 1 commit intoveraison:mainfrom
qmuntal:main
Nov 14, 2022
Merged

Use cbor.SortCoreDeterministic for CBOR encoding#113
thomas-fossati merged 1 commit intoveraison:mainfrom
qmuntal:main

Conversation

@qmuntal
Copy link
Copy Markdown
Member

@qmuntal qmuntal commented Nov 4, 2022

Fixes #110

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2022

Codecov Report

Merging #113 (b2a1e5f) into main (77e3f9f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          10       10           
  Lines         975      975           
=======================================
  Hits          895      895           
  Misses         54       54           
  Partials       26       26           
Impacted Files Coverage Δ
cbor.go 84.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Copy Markdown
Contributor

@qmuntal The notation-core-go project works well with the go-cose in this PR as confirmed by @patrickzheng200.

@qmuntal
Copy link
Copy Markdown
Member Author

qmuntal commented Nov 10, 2022

@thomas-fossati @yogeshbdeshpande PTAL

Copy link
Copy Markdown
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @qmuntal !

@qmuntal
Copy link
Copy Markdown
Member Author

qmuntal commented Nov 14, 2022

Can this be merged? Thanks!

@thomas-fossati thomas-fossati merged commit f72b6bc into veraison:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine if CBOR map key sort order setting should be updated because RFC 9052 obsoleted RFC 8152

3 participants