Improve README.md examples#111
Merged
yogeshbdeshpande merged 1 commit intoveraison:mainfrom Nov 4, 2022
Merged
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 89.74% 91.79% +2.04%
==========================================
Files 10 10
Lines 985 975 -10
==========================================
+ Hits 884 895 +11
+ Misses 67 54 -13
+ Partials 34 26 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
@yogeshbdeshpande can you take a look at this? |
Member
Author
|
I don't have merge permissions, need someone to do that for me :) |
Contributor
|
Done! and Thank you for the Excellent Work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the examples in the README.md to make it clear that the errors should be handled someway and also clarify hash function requirements.
Fixes #106