Update cose-spec from draft to RFC 9052#109
Merged
SteveLasker merged 1 commit intoveraison:mainfrom Oct 7, 2022
Merged
Conversation
Contributor
|
Thanks very much @fxamacker Could you please fix the failing DCO check so that we can merge, please? |
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 91.79% 92.10% +0.30%
==========================================
Files 10 10
Lines 975 975
==========================================
+ Hits 895 898 +3
+ Misses 54 51 -3
Partials 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Replace cose-spec from https://datatracker.ietf.org/doc/draft-ietf-cose-rfc8152bis-struct/ to https://datatracker.ietf.org/doc/rfc9052/ Signed-off-by: Faye Amacker <33205765+fxamacker@users.noreply.github.com>
roywill
approved these changes
Oct 7, 2022
SteveLasker
approved these changes
Oct 7, 2022
Contributor
SteveLasker
left a comment
There was a problem hiding this comment.
LGTM, great progress
Contributor
|
Thanks @fxamacker, and welcome to the go-cose family |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cose-spec
from https://datatracker.ietf.org/doc/draft-ietf-cose-rfc8152bis-struct/
to https://datatracker.ietf.org/doc/rfc9052/
Closes #108