Skip to content

feat: Propagate attributes to parent context#36

Merged
veqryn merged 6 commits intoveqryn:mainfrom
pazams:pazams/propagation_to_parent
Jan 28, 2026
Merged

feat: Propagate attributes to parent context#36
veqryn merged 6 commits intoveqryn:mainfrom
pazams:pazams/propagation_to_parent

Conversation

@pazams
Copy link
Copy Markdown
Contributor

@pazams pazams commented Oct 4, 2025

Following discussion from #34

  • Adds feature to propagate attributes to parent context
  • Refactor the sloghttp sub package to use this feature

cc @veqryn

@pazams pazams mentioned this pull request Oct 4, 2025
Open
pazams
pazams commented Oct 5, 2025
View reviewed changes
@veqryn
Copy link
Copy Markdown
Owner

veqryn commented Oct 16, 2025

What would you think of moving the propagation stuff to its own package, like slog-context/propagation ?
We'd have to change the method names a little, such as InitPropagation -> Init, etc.
I just concerned about adding more methods to the root package, which already has a lot.

@pazams
Copy link
Copy Markdown
Contributor Author

pazams commented Oct 19, 2025

Absolutely, I probably just misunderstood your comment from
#34

I'd be happy to accept a PR from you that moves the logic to the root package

Please see the refactor commit 642ece3

@veqryn
Copy link
Copy Markdown
Owner

veqryn commented Oct 20, 2025

looks good. i am just debating in my head if I want the method to be called Add or something else, like With

@pazams
Copy link
Copy Markdown
Contributor Author

pazams commented Oct 24, 2025

looks good. i am just debating in my head if I want the method to be called Add or something else, like With

Happy to rename any method - let me know!

@pazams
Copy link
Copy Markdown
Contributor Author

pazams commented Dec 1, 2025

gentle bump 🙏

veqryn
veqryn reviewed Dec 2, 2025
View reviewed changes
veqryn
veqryn reviewed Dec 2, 2025
View reviewed changes
veqryn
veqryn reviewed Dec 2, 2025
View reviewed changes
@veqryn
Copy link
Copy Markdown
Owner

veqryn commented Dec 2, 2025

gentle bump 🙏

Sorry for the delay, life is crazy right now.
I made a few more requested changes please.

@pazams
Copy link
Copy Markdown
Contributor Author

pazams commented Jan 19, 2026

Sorry for the delay, life is crazy right now.
I made a few more requested changes please.

No worries! I too had some impediments.
I made the first two changes, and commented on the third.
@veqryn let me know your thoughts ?

veqryn
veqryn approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@veqryn veqryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@veqryn veqryn merged commit 4d44656 into veqryn:main Jan 28, 2026
24 checks passed
@veqryn
Copy link
Copy Markdown
Owner

veqryn commented Jan 28, 2026

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veqryn veqryn veqryn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pazams @veqryn