Merged
Conversation
This seems to be the way jsonapi-resources does it. Although, at some points JR passes way more information down the chain. Unfortunately, that same information is not available in PunditScopedResource so I'll just go with what we can get in all the places. https://github.com/cerebris/jsonapi-resources/blob/5af1f17068b66b0a17b7b69e5db334c640f6f34b/lib/jsonapi/processor.rb#L170-L184
Member
Author
|
@Justin-Maxwell, could you test this out to make sure that this indeed fixes your problems found in #80? You should be able to install this version by listing |
Member
Author
|
Hey @Justin-Maxwell, any chance to test this branch out to see if it fixes your issue? |
Member
Author
|
I'll just assume that this fixed #80 — this change should make sense either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #80
It seems to be that JR always passes a hash to the
relation_nameaccessors, with thecontextunder key:contexthttps://github.com/cerebris/jsonapi-resources/blob/v0.9.0/lib/jsonapi/resource.rb#L250
Let's just use that everywhere in
jsonapi-authorization, too.It's a bit odd that JR passes way more information down the same
relation_namewhen in the scope of processor, but that doesn't seem to be important to us. Documentation only refers to fetching thecontextfrom the options, and AFAICT, doesn't tell about what else is in the options hash:http://jsonapi-resources.com/v0.9/guide/resources.html#Options