add possibility to react on will display header and footer#97
Closed
rad3ks wants to merge 1 commit intovenmo:masterfrom
Closed
add possibility to react on will display header and footer#97rad3ks wants to merge 1 commit intovenmo:masterfrom
rad3ks wants to merge 1 commit intovenmo:masterfrom
Conversation
Contributor
|
Coming in way late to this PR, but what is it's use here? Tracking? Animations? Resizing? |
Contributor
|
I would really like to access |
Contributor
|
@txaiwieser access scrollViewDidScroll: ? Oftentimes, if there are several parties involved, I steer clear of delegate methods unless I for sure own that delegate. In your case, could you leverage an observer: |
Contributor
|
I believe my PR solves this in the best way: #119 You don't want to need to create a bunch of closures for each message in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #78 I decided to make small PR with possibility to quickly access two methods of
UITableViewDelegate:tableView(_:, willDisplayHeaderView:, forSection:)tableView(_:, willDisplayFooterView:, forSection:)The reason we need to have the simplest possibility to access those method is that
UIKitsomehow overrides header view appearance (forUITableViewHeaderFooterVIew) and those two methods can be used for configuring header/footer correctly.The solution here is to provide two closures:
dataSource.willDisplayHeader: ((UIView, Int) -> Void)?dataSource.willDisplayFooter: ((UIView, Int) -> Void)?I wish we could have better architecture for that than just a properties with closures, but this solution fulfills two most important requirements:
Static