On mac, move MacOS/sq.version to Resources/sq.version and symlink it. Workaround for code signature not being preserved after updates. #705
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Workaround for code signature not being preserved after updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Mac apps have an invalid signature after updating.
This is because the file
MyApp.app/Contents/MacOS/sq.versionis text, so its code signature is stored in a macos extended attribute, which gets lost when packaged into a.nupkg. (binary files' signatures get stored in the binaries themselves, rather than in xattrs)refs:
This PR demonstrates a workaround: put
sq.versionin the Resources folder instead, so it can be unsigned. Then we can symlink to it fromMacOS/sq.version, since symlinks in the MacOS folder don't need to be signed.Of course, this doesn't solve the issue of other text files that users may want to codesign, but that's a job for #63