Skip to content

Conversation

@thojaw
Copy link
Contributor

@thojaw thojaw commented May 15, 2025

@caesay this is my take on the changes related to header updates as discussed in #641

I explicitly wanted to split this so this update does NOT include the actual problematic changes related to the self hosted gitlab instance.

Also, I had some issues with unit tests on my machine. I'll need to await a CI build (hopefully, there is one 😄 )

Attention: As discussed, this Api is breaking the API without fall back compatibility when using custom Downloaders.

@thojaw thojaw force-pushed the UpdateDownloaderHeaderUsage branch from 9fb3c12 to d765297 Compare May 16, 2025 18:16
@caesay
Copy link
Member

caesay commented May 18, 2025

This looks really good. We have integration tests for github (but none for gitlab/gitea). Does the PRIVATE-TOKEN header apply to the public gitlab instance or only self hosted ones?

@codecov
Copy link

codecov bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 38.21%. Comparing base (4cdbb49) to head (8447be9).
Report is 33 commits behind head on develop.

Files with missing lines Patch % Lines
src/lib-csharp/Sources/GitBase.cs 0.00% 13 Missing ⚠️
src/lib-csharp/Sources/GiteaSource.cs 0.00% 7 Missing ⚠️
src/lib-csharp/Sources/GithubSource.cs 0.00% 7 Missing ⚠️
src/lib-csharp/Sources/GitlabSource.cs 0.00% 5 Missing and 1 partial ⚠️
src/lib-csharp/Sources/HttpClientFileDownloader.cs 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #645      +/-   ##
===========================================
- Coverage    40.13%   38.21%   -1.92%     
===========================================
  Files          230      230              
  Lines        17066    17089      +23     
  Branches      2047     2045       -2     
===========================================
- Hits          6849     6531     -318     
- Misses        9860    10228     +368     
+ Partials       357      330      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@caesay
Copy link
Member

caesay commented May 18, 2025

Also, I ran across some info saying GitLab "Private Tokens" have been deprecated (here's the changelog https://gitlab.com/gitlab-org/gitlab-foss/-/blob/10-2-stable/CHANGELOG.md#1020-2017-11-22) and that PAT's should be used now instead?

@caesay caesay closed this May 18, 2025
@caesay caesay reopened this May 18, 2025
@thojaw
Copy link
Contributor Author

thojaw commented May 19, 2025

@caesay this is interesting. I thought that this would be the same thing effectively.
In my instance, I go to "Acccess Tokens"...

image

and create a new PAT...

image

...but that's the token I need to send using the PRIVATE-TOKEN header.

I'm also not aware of any difference between self-hosted and public instance of gitlab, as long as you're using a quite matching version (e.g. API Version 4, not sure how it was in 3 etc.)

Do you think we need another PR update?

@thojaw thojaw force-pushed the UpdateDownloaderHeaderUsage branch from e3056f5 to 8447be9 Compare May 19, 2025 06:54
@caesay caesay merged commit d05fdd6 into velopack:develop May 23, 2025
28 checks passed
@thojaw thojaw deleted the UpdateDownloaderHeaderUsage branch May 25, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants