-
-
Notifications
You must be signed in to change notification settings - Fork 104
Refactor downloader methods to use a dictionary for headers #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9fb3c12 to
d765297
Compare
|
This looks really good. We have integration tests for github (but none for gitlab/gitea). Does the PRIVATE-TOKEN header apply to the public gitlab instance or only self hosted ones? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #645 +/- ##
===========================================
- Coverage 40.13% 38.21% -1.92%
===========================================
Files 230 230
Lines 17066 17089 +23
Branches 2047 2045 -2
===========================================
- Hits 6849 6531 -318
- Misses 9860 10228 +368
+ Partials 357 330 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also, I ran across some info saying GitLab "Private Tokens" have been deprecated (here's the changelog https://gitlab.com/gitlab-org/gitlab-foss/-/blob/10-2-stable/CHANGELOG.md#1020-2017-11-22) and that PAT's should be used now instead? |
|
@caesay this is interesting. I thought that this would be the same thing effectively. and create a new PAT... ...but that's the token I need to send using the I'm also not aware of any difference between self-hosted and public instance of gitlab, as long as you're using a quite matching version (e.g. API Version 4, not sure how it was in 3 etc.) Do you think we need another PR update? |
e3056f5 to
8447be9
Compare


@caesay this is my take on the changes related to header updates as discussed in #641
I explicitly wanted to split this so this update does NOT include the actual problematic changes related to the self hosted gitlab instance.
Also, I had some issues with unit tests on my machine. I'll need to await a CI build (hopefully, there is one 😄 )
Attention: As discussed, this Api is breaking the API without fall back compatibility when using custom Downloaders.