Send all library logs to velopack.log by default #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #541 +/- ##
===========================================
+ Coverage 34.55% 40.18% +5.63%
===========================================
Files 224 230 +6
Lines 16810 17006 +196
Branches 1999 2045 +46
===========================================
+ Hits 5808 6834 +1026
+ Misses 10664 9815 -849
- Partials 338 357 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
08bcb66 to
4715437
Compare
Keboo
previously approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #465
Closes #545
The logging callbacks have been preserved, but now velopack client libraries will log to the default file log as well.
This PR also removed Microsoft.Extensions.Logging from this library in favor of a small internal logging interface. Developers who do not present logs to users in their UI can rely on all the velopack logs now being present in
velopack.loginstead of capturing.