Fix update lock after download interruption #520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow, thanks for finding this. Someone reported something similar about partial downloads in the past but I did not see the problem. I have fixed this slightly differently in #521 but thanks a lot for taking the time to write a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the download process of update packages is interrupted (due to network issues or the user closing the app), the "UpdateManager" still renames the download file and removes the ".partial" extension, resulting in an invalid package that cannot be applied and causing the download of the latest version to become locked.
Hi, I propose the following changes to address these issues, but you might have a clearer understanding of how to avoid them. Thanks anyway :)