Codecov Report

Attention: Patch coverage is 79.43925% with 22 lines in your changes missing coverage. Please review.

Project coverage is 40.09%. Comparing base (4f5f4c5) to head (908db16).
Report is 7 commits behind head on develop.

@@             Coverage Diff             @@
##           develop     #486      +/-   ##
===========================================
+ Coverage    39.88%   40.09%   +0.20%     
===========================================
  Files          224      224              
  Lines        16490    16575      +85     
  Branches      1995     2009      +14     
===========================================
+ Hits          6577     6645      +68     
- Misses        9578     9586       +8     
- Partials       335      344       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Overall most of my comments stem from the fact that our current PackageBuilder is a bit hacky and isn't configurable. I would eventually like to refactor so each override (eg. WindowsPackageBuilder) can provide a list of tasks to be completed, and the dependencies between the tasks (for parallelism) - in which case having a separate line item for WiX would be easy to do. We could do this refactoring now, or we could just squash the WiX stuff into the existing Setup task.