Skip to content

Fix memory violation crash for lib-cpp when there is no download progress callback #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caesay merged 2 commits into from
Nov 28, 2024
Merged

Fix memory violation crash for lib-cpp when there is no download progress callback #384

caesay merged 2 commits into from
Nov 28, 2024

Conversation

@caesay
Copy link
Member

@caesay caesay commented Nov 28, 2024 •
edited
Loading

Closes #379

@codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 122 lines in your changes missing coverage. Please review.

Project coverage is 45.64%. Comparing base (c9721bf) to head (967d860).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/lib-cpp/src/lib.rs 0.00% 91 Missing ⚠️
src/lib-cpp/src/types.rs 0.00% 31 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #384      +/-   ##
===========================================
- Coverage    45.70%   45.64%   -0.06%     
===========================================
  Files          224      224              
  Lines        13624    13641      +17     
  Branches      1249     1249              
===========================================
  Hits          6227     6227              
- Misses        7082     7099      +17     
  Partials       315      315

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caesay caesay merged commit 9fa9dba into develop Nov 28, 2024
25 checks passed
@caesay caesay deleted the cs/cpp-memory-crash branch November 28, 2024 22:01
@caesay caesay mentioned this pull request Dec 4, 2024
Closed
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Closed
@dependabot dependabot bot mentioned this pull request Aug 19, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 27, 2025
Closed
@dependabot dependabot bot mentioned this pull request Dec 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CppWin32Sample.exe Crash When Click "Download update" button

2 participants

@caesay